Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move from travis to github actions #316

Merged
merged 13 commits into from
Sep 16, 2021
Merged

Move from travis to github actions #316

merged 13 commits into from
Sep 16, 2021

Conversation

mvanlonden
Copy link
Member

@mvanlonden mvanlonden commented Sep 5, 2021 •
edited
Loading

graphql-python/graphene#1127

Use github action for linting, deploying and testing. Removes travis.

Fixes automated deploys.

@mvanlonden mvanlonden requested a review from jnak September 5, 2021 23:23
@mvanlonden
Copy link
Member Author

mvanlonden commented Sep 5, 2021 •
edited
Loading

@jetzhou This PR fixes the deploy script to unblock v3 migration

@mvanlonden mvanlonden requested a review from abawchen September 5, 2021 23:43
@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@20ecaea). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #316   +/-   ##
=========================================
  Coverage          ?   97.65%           
=========================================
  Files             ?        9           
  Lines             ?      596           
  Branches          ?        0           
=========================================
  Hits              ?      582           
  Misses            ?       14           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20ecaea...19c63ff. Read the comment docs.

@mvanlonden mvanlonden requested a review from jkimbo September 7, 2021 21:23
jkimbo
jkimbo approved these changes Sep 8, 2021
View reviewed changes
Copy link
Member

@jkimbo jkimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The code coverage doesn't seem to be working though.

tox.ini
Comment on lines +8 to +9
2.7: py27
3.5: py35
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These can probably be removed since they're not being tested against.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will follow up with coverage fix and removing these tests

@richin13
Copy link
Contributor

Can we get this merged? 🙏🏼 I'd like to run the tests on PR #317 (currently they're passing locally). This is important to get graphene to v3

@richin13 richin13 mentioned this pull request Sep 10, 2021
Closed
8 tasks
@mvanlonden mvanlonden merged commit cba727c into master Sep 16, 2021
@mvanlonden mvanlonden mentioned this pull request Sep 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkimbo jkimbo jkimbo approved these changes

@jnak jnak Awaiting requested review from jnak

@abawchen abawchen Awaiting requested review from abawchen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mvanlonden @codecov-commenter @richin13 @jkimbo